Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Report Metric of Personal User creating a team in Countly (WPB-11318) #3552

Merged
merged 32 commits into from
Oct 31, 2024
Merged

feat: Report Metric of Personal User creating a team in Countly (WPB-11318) #3552

merged 32 commits into from
Oct 31, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 23, 2024 •
edited by github-actions bot
Loading

StoryWPB-11318 [Android] Report Metric of Personal User creating a team in Countly

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Report events related to team migration according to the accetence creteria defined here

https://wearezeta.atlassian.net/browse/WPB-11318

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine
feat: personal to team migration flow
71f73a0
@ohassine
feat: make some round corner shape
c8ae19e
@ohassine
Merge branch 'develop' into team_upgrade_flow
f2fe3fd
@ohassine
chore: remove unused composable
e6ea363
@ohassine
chore: add contentDescription
8465e85
@ohassine
Merge remote-tracking branch 'origin/develop' into team_upgrade_flow
85d6c9f
@ohassine
feat: open screen to create a team
c4c68eb
@ohassine
Merge branch 'develop' into team_upgrade_flow
58e8467
@ohassine
chore: address comments
c003dd4
@ohassine
Merge remote-tracking branch 'origin/team_upgrade_flow' into team_upg…
7b2eaca 
…rade_flow
@ohassine
Merge branch 'develop' into team_upgrade_flow
9832761
@ohassine
feat: Report Metric of Personal User creating a team in Countly
065eb41
@ohassine
Merge remote-tracking branch 'origin/develop' into team_upgrade_countly
e8c230b
@ohassine
Merge remote-tracking branch 'origin/develop' into team_upgrade_countly
7f44fef 
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/PersonalToTeamMigrationNavGraph.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModel.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step1/TeamMigrationTeamPlanStepScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step2/TeamMigrationTeamNameStepScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step3/TeamMigrationConfirmationStepScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/step4/TeamMigrationDoneStepScreen.kt
#	app/src/main/res/values/strings.xml
@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, borichellow, MohamadJaara and damian-kaczmarek and removed request for a team October 23, 2024 15:08
@ohassine
chore: detekt
0bfe555
@ohassine
chore: cleanup
d211b8e
@ohassine
chore: unit test
885f69f
@ohassine
Merge remote-tracking branch 'origin/develop' into team_upgrade_countly
05658c2 
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModel.kt
@ohassine
chore: detekt
d4c5091
@ohassine
chore: remove duplicated composable
002df22
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.34%. Comparing base (7993fc5) to head (ebdfbb7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3552      +/-   ##
===========================================
+ Coverage    45.21%   45.34%   +0.13%     
===========================================
  Files          472      472              
  Lines        15765    15790      +25     
  Branches      2633     2633              
===========================================
+ Hits          7128     7160      +32     
+ Misses        7887     7880       -7     
  Partials       750      750
Files with missing lines Coverage Δ
...kotlin/com/wire/android/datastore/UserDataStore.kt 30.76% <ø> (ø)
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 60.00% <100.00%> (+1.50%) ⬆️
...serprofile/teammigration/TeamMigrationViewModel.kt 100.00% <100.00%> (+100.00%) ⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 53.06% <66.66%> (+0.97%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7993fc5...ebdfbb7. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3552.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3552.apk is available for download

damian-kaczmarek
damian-kaczmarek approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with debug mode. We have empty implementation for analytics for non production builds. Maybe we want to add some implementation with prints for easier verification if right analytics actions are called?

@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 30, 2024
@ohassine ohassine removed this pull request from the merge queue due to a manual request Oct 30, 2024
@ohassine
Merge remote-tracking branch 'origin/develop' into team_upgrade_countly
e018694 
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModel.kt
#	app/src/test/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModelArrangement.kt
#	core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
@ohassine
feat: send only the required segmentations
4a5f1a4
@ohassine
Merge remote-tracking branch 'origin/team_upgrade_countly' into team_…
6332dfd 
…upgrade_countly
@ohassine
feat: update default value
87c88bf
@ohassine
feat: send segmentations
654afcd
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ohassine ohassine added this pull request to the merge queue Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3552.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3552.apk is available for download

Merged via the queue into develop with commit f529c34 Oct 31, 2024
11 of 12 checks passed
@ohassine ohassine deleted the team_upgrade_countly branch October 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-kaczmarek damian-kaczmarek damian-kaczmarek approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina yamilmedina was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
echoes/initiative: personal-users-to-team-users... size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @codecov-commenter @MohamadJaara @damian-kaczmarek